Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DST better in Task Instance tool tips #8104

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

ashb
Copy link
Member

@ashb ashb commented Apr 3, 2020

We displayed the zone "name" based on the current time, which could lead
to confusion when the date to be displayed was not in the same
daylight-savings state as "now".

image (1)


Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

We displayed the zone "name" based on the current time, which could lead
to confusion when the date to be displayed was not in the same
daylight-savings state as "now".
@ashb ashb added this to the Airflow 1.10.10 milestone Apr 3, 2020
@ashb ashb requested a review from kaxil April 3, 2020 17:32
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 3, 2020
@kaxil kaxil merged commit 1000b4b into apache:master Apr 3, 2020
@ashb ashb deleted the ti-tooltip-dst-aware branch April 3, 2020 17:33
@kaxil
Copy link
Member

kaxil commented Apr 3, 2020

Tested it manually, need it for RC2

kaxil pushed a commit that referenced this pull request Apr 3, 2020
We displayed the zone "name" based on the current time, which could lead
to confusion when the date to be displayed was not in the same
daylight-savings state as "now".

(cherry picked from commit 1000b4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants