Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes #8147

Merged

Conversation

brandonwillard
Copy link
Contributor

@brandonwillard brandonwillard commented Apr 5, 2020

Added a kubernetes.dags_volume_mount_point option.

This PR is replacing #7401 (moved to my personal fork).


Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added area:Scheduler including HA (high availability) scheduler k8s labels Apr 5, 2020
@brandonwillard brandonwillard force-pushed the add-k8s-dags-mount-point-option branch from 4fafd52 to 3fc285d Compare April 5, 2020 00:32
@codecov-io
Copy link

codecov-io commented Apr 5, 2020

Codecov Report

Merging #8147 into master will increase coverage by 21.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #8147       +/-   ##
===========================================
+ Coverage   66.39%   88.22%   +21.83%     
===========================================
  Files         935      935               
  Lines       45170    45173        +3     
===========================================
+ Hits        29990    39856     +9866     
+ Misses      15180     5317     -9863     
Impacted Files Coverage Δ
airflow/executors/kubernetes_executor.py 56.96% <100.00%> (+39.88%) ⬆️
airflow/kubernetes/worker_configuration.py 99.31% <100.00%> (+81.25%) ⬆️
airflow/providers/google/cloud/operators/vision.py 99.63% <0.00%> (+0.36%) ⬆️
...osoft/azure/operators/azure_container_instances.py 78.28% <0.00%> (+0.65%) ⬆️
airflow/cli/cli_parser.py 97.24% <0.00%> (+0.91%) ⬆️
airflow/providers/postgres/hooks/postgres.py 94.36% <0.00%> (+1.40%) ⬆️
...rflow/providers/databricks/operators/databricks.py 92.24% <0.00%> (+1.72%) ⬆️
.../providers/google/cloud/operators/presto_to_gcs.py 38.66% <0.00%> (+2.66%) ⬆️
airflow/models/log.py 100.00% <0.00%> (+3.03%) ⬆️
airflow/executors/celery_executor.py 88.51% <0.00%> (+3.37%) ⬆️
... and 495 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d1714...3fc285d. Read the comment docs.

@dimberman dimberman merged commit 75896c3 into apache:master Apr 7, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 7, 2020

Awesome work, congrats on your first merged pull request!

@dimberman dimberman added this to the Airflow 1.10.11 milestone Apr 7, 2020
BARK-RNANDA pushed a commit to BARK-RNANDA/airflow that referenced this pull request Apr 23, 2020
dimberman pushed a commit that referenced this pull request Jun 25, 2020
potiuk pushed a commit that referenced this pull request Jun 29, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants