-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: Fix writing & deleting Dag Code for Serialized DAGs #8151
Conversation
Codecov Report
@@ Coverage Diff @@
## v1-10-test #8151 +/- ##
==============================================
- Coverage 81.81% 81.29% -0.52%
==============================================
Files 541 541
Lines 37178 37178
==============================================
- Hits 30417 30225 -192
- Misses 6761 6953 +192
Continue to review full report at Codecov.
|
Tests have passed, failing tests is for Generating requirements.txt and is unrelated |
@kaxil Thank you for the patch! I've applied it on my installation, and the However, new errors appeared in scheduler:
and
Do these look like related bugs? |
Yep. Rebase should help with that. |
@KostyaEsmukov Can you please check now with the patch in this PR. 🤞 All problems should be solved. I have tested locally and DagCode is successfully saved in the DB and overwritten when a file has changed too |
@kaxil Thanks for the fix! The scheduler errors are gone, but on a stateless webserver the code is still not rendered, because, apparently,
Notice the |
Are you on Airflow Slack (https://apache-airflow-slack.herokuapp.com/), would you mind signing up if you are not so that we can check this together :) |
With
store_dag_code
enabled scheduler throws the following error:This is a blocker for 1.10.10 and the bug was found in 1.10.10rc2 by Kostya Esmukov
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.