Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 500 error in Security screens #8165

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Fix 500 error in Security screens #8165

merged 1 commit into from
Apr 6, 2020

Conversation

ashb
Copy link
Member

@ashb ashb commented Apr 6, 2020

PR #8046 used our CustomSQLAInterface more widely, and we weren't
correctly implementing the interface right in the constructor, which was
only a problem for models which use Relations, which we don't in
Airflow, but FAB does for it's user/permissions models.

Closes #8156

Make sure to mark the boxes below before creating PR: [x]

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@ashb
Fix 500 error in Security screens
532ca11 
PR apache#8046 used our CustomSQLAInterface more widely, and we weren't
correctly implementing the interface right in the constructor, which was
only a problem for models which use Relations, which we don't in
Airflow, but FAB does for it's user/permissions models.
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 6, 2020
@ashb ashb requested a review from kaxil April 6, 2020 16:41
@ashb ashb added this to the Airflow 1.10.10 milestone Apr 6, 2020
@kaxil kaxil merged commit 0dafdd0 into apache:master Apr 6, 2020
kaxil pushed a commit that referenced this pull request Apr 6, 2020
@ashb @kaxil
Fix 500 error in Security screens (#8165)
515975c 
PR #8046 used our CustomSQLAInterface more widely, and we weren't
correctly implementing the interface right in the constructor, which was
only a problem for models which use Relations, which we don't in
Airflow, but FAB does for it's user/permissions models.

cherry-picked from 0dafdd0
@ashb ashb deleted the fab-security-screen-fix branch April 6, 2020 17:14
kaxil added a commit to kaxil/airflow that referenced this pull request Apr 7, 2020
@kaxil
Add tests for Security Views
d51c7e3 
This would avoid cases like the one that was solved in apache#8165
@kaxil kaxil mentioned this pull request Apr 7, 2020
Merged
5 tasks
kaxil added a commit that referenced this pull request Apr 7, 2020
@kaxil
Add tests for Security Views (#8180)
17fbd7a 
This would avoid cases like the one that was solved in #8165
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 15, 2021
@kaxil
Add tests for Security Views (#8180)
5b39bf2 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2021
@kaxil
Add tests for Security Views (#8180)
f0d072c 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021
@kaxil
Add tests for Security Views (#8180)
01193c6 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 25, 2021
@kaxil
Add tests for Security Views (#8180)
3959496 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 9, 2022
@kaxil
Add tests for Security Views (#8180)
37c08d8 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 3, 2022
@kaxil
Add tests for Security Views (#8180)
4d9a47e 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 6, 2022
@kaxil
Add tests for Security Views (#8180)
49ad4cb 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 8, 2022
@kaxil
Add tests for Security Views (#8180)
9e211ef 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 26, 2022
@kaxil
Add tests for Security Views (#8180)
fbba471 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 3, 2022
@kaxil
Add tests for Security Views (#8180)
64340f0 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
@kaxil
Add tests for Security Views (#8180)
613e5d0 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
@kaxil
Add tests for Security Views (#8180)
a9973f3 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
@kaxil
Add tests for Security Views (#8180)
ac98be7 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 11, 2024
@kaxil
Add tests for Security Views (#8180)
07673f3 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
@kaxil
Add tests for Security Views (#8180)
481e473 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 16, 2024
@kaxil
Add tests for Security Views (#8180)
44249f3 
This would avoid cases like the one that was solved in apache/airflow#8165

GitOrigin-RevId: 17fbd7a9d8930a5fd252b3db8f6574d4375b8a52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxil kaxil kaxil approved these changes

Assignees
No one assigned
Labels
area:webserver Webserver related Issues
Projects
None yet
Milestone
Airflow 1.10.10
Development

Successfully merging this pull request may close these issues.

Security Views broken
2 participants
@ashb @kaxil