Improve add_dag_code_table migration #8176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Apr 7, 2020
This migration had a few problems that could cause us trouble in the future: 1. It was importing the live model definition, which could break in the future (if for instance it ever got a new column added, when this migration runs it would try to use that new definition, but the column won't exist yet). 2. It was selecting the (large) `data` column needlessly 3. It was dropping and re-creating the index but that is only needed on MSSQL, not for MySQL or Postgresql.
ashb
force-pushed
the
dont-import-models-for-migrations
branch
from
5301862
to
9df3fba
Compare
|
/cc @anitakar - just as an FYI mostly. |
kaxil
reviewed
Apr 7, 2020
kaxil
pushed a commit
that referenced
this pull request
Apr 14, 2020
This migration had a few problems that could cause us trouble in the future: 1. It was importing the live model definition, which could break in the future (if for instance it ever got a new column added, when this migration runs it would try to use that new definition, but the column won't exist yet). 2. It was selecting the (large) `data` column needlessly 3. It was dropping and re-creating the index but that is only needed on MSSQL, not for MySQL or Postgresql. (cherry picked from commit 88e756e)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
This migration had a few problems that could cause us trouble in the future: 1. It was importing the live model definition, which could break in the future (if for instance it ever got a new column added, when this migration runs it would try to use that new definition, but the column won't exist yet). 2. It was selecting the (large) `data` column needlessly 3. It was dropping and re-creating the index but that is only needed on MSSQL, not for MySQL or Postgresql. (cherry picked from commit 88e756e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration was added in #7217 had a few problems that could cause us trouble in the
future:
future (if for instance it ever got a new column added, when this
migration runs it would try to use that new definition, but the
column won't exist yet).
datacolumn needlesslyMSSQL, not for MySQL or Postgresql.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.