Proper version is displayed when running prod image via Breeze

[potiuk]

---

Make sure to mark the boxes below before creating PR: [x]

• Description above provides context of the change
• Unit tests coverage for changes (not needed for documentation changes)
• Commits follow "How to write a good git commit message"
• Relevant documentation is updated including usage instructions.
• I will engage committers as explained in Contribution Workflow Example.

---

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

[potiuk]

Note that this is only applicable to production image. --install-airflow-version in CI works slightly differently. In production image it builds a new image. In CI image it installs airflow version in the original "2.0" image (uninstalls airflow 2.0 first). This is much faster and OK for testing. For production image - we really want to build the image in an optimal way so the image is rebuild using the version of airflow provided via --install-airflow-version flag.

[codecov-io]

Codecov Report

Merging #8229 into master will decrease coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8229      +/-   ##
==========================================
- Coverage   88.35%   87.92%   -0.44%     
==========================================
  Files         936      936              
  Lines       45305    46065     +760     
==========================================
+ Hits        40030    40503     +473     
- Misses       5275     5562     +287     

Impacted Files	Coverage Δ
...flow/providers/apache/cassandra/hooks/cassandra.py	21.25% <0.00%> (-72.50%)	⬇️
...w/providers/apache/hive/operators/mysql_to_hive.py	35.84% <0.00%> (-64.16%)	⬇️
airflow/providers/postgres/operators/postgres.py	47.82% <0.00%> (-52.18%)	⬇️
airflow/providers/redis/operators/redis_publish.py	50.00% <0.00%> (-50.00%)	⬇️
airflow/providers/mongo/sensors/mongo.py	53.33% <0.00%> (-46.67%)	⬇️
airflow/providers/mysql/operators/mysql.py	55.00% <0.00%> (-45.00%)	⬇️
airflow/providers/redis/sensors/redis_key.py	61.53% <0.00%> (-38.47%)	⬇️
airflow/executors/celery_executor.py	50.67% <0.00%> (-37.84%)	⬇️
...roviders/google/cloud/operators/postgres_to_gcs.py	54.28% <0.00%> (-31.43%)	⬇️
airflow/providers/postgres/hooks/postgres.py	78.87% <0.00%> (-15.50%)	⬇️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad42c40...2a6a7b5. Read the comment docs.

[potiuk]

Hey @feluelle - can you double check if this works :) ?

[feluelle]

Works. Thanks @potiuk :)

[feluelle]

@potiuk That is really weird -> $AIRFLOW_VERSION shows 1.10.10 also airflow version shows 1.10.10 but endpoint /version shows 2.0.0

1. ./breeze build-image --production-image --install-airflow-version=1.10.10
2. ./breeze --production-image
3. airflow upgradedb
4. airflow webserver
5. http://0.0.0.0:28080/version

EDIT:

being on git branch #8228 (and rebased on latest master)

[potiuk]

it is :). Looking at it

[potiuk]

Can you try the same with --skip-mounting-local-sources switch? I think this might be the reason and we might want to simply not mount "airflow" sources at all (the change I just approved and merged today).

[feluelle]

with --skip-mounting-local-sources I cannot reach the webserver probably because the compose file (local-prod) won't be used at all.

When I remove all volumes in the compose and run normally - it works :) /version shows 1.10.10

[potiuk]

YEah. I think the reason was source mapping to inside the container. I left comment in #8228 to remove all the /opt/airflow mounts. This might be super-misleading if we leave them.

[potiuk]

Luckily I have not yet merged it so you can still fix it :)

[feluelle]

Will do - thanks for helping :)