[AIRFLOW-6885] Change delete-on-success to delete-on-failure #8312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:Scheduler
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #8312 +/- ##
===========================================
- Coverage 88.43% 60.74% -27.69%
===========================================
Files 940 940
Lines 45353 45354 +1
===========================================
- Hits 40108 27551 -12557
- Misses 5245 17803 +12558
Continue to review full report at Codecov.
|
ashb
reviewed
Apr 15, 2020
ashb
reviewed
Apr 15, 2020
ashb
reviewed
Apr 15, 2020
dimberman
force-pushed
the
change-to-delete-on-failure
branch
from
36f27ba
to
18e3d24
Compare
ashb
approved these changes
Apr 15, 2020
It makes more sense to by-default not delete failed pods Users should explicitly state they want these pods deleted. This feature has not yet been released so ethis will not be a breaking change
dimberman
force-pushed
the
change-to-delete-on-failure
branch
from
18e3d24
to
1fe3905
Compare
kaxil
changed the title
kaxil
approved these changes
Apr 15, 2020
kaxil
pushed a commit
that referenced
this pull request
Apr 16, 2020
* Change delete-on-success to delete-on-failure It makes more sense to by-default not delete failed pods Users should explicitly state they want these pods deleted. This feature has not yet been released so ethis will not be a breaking change * deps * deps Co-authored-by: Daniel Imberman <[email protected]>
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Change delete-on-success to delete-on-failure It makes more sense to by-default not delete failed pods Users should explicitly state they want these pods deleted. This feature has not yet been released so ethis will not be a breaking change * deps * deps Co-authored-by: Daniel Imberman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/AIRFLOW-6885
It makes more sense to by-default not delete failed pods
Users should explicitly state they want these pods deleted.
This feature has not yet been released so ethis will not be a breaking
change
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.