Catch ProgrammingError raised by MSSQL which doesn't know JSON_VALID() #8385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Apr 16, 2020
6 tasks
kaxil
pushed a commit
that referenced
this pull request
Jun 16, 2020
(cherry picked from commit a160886)
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
(cherry picked from commit a160886)
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
(cherry picked from commit a160886)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
(cherry picked from commit a160886)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #6920, this PR catches a ProgrammingError during migration of the
rendered_task_instance_fieldstable, which will be raised by MSSQL because it doesn't knowJSON_VALID().Not sure if to test this, since Airflow doesn't actively support MSSQL and doesn't test it in the CI.
Note: this table was added in Airflow 1.10.10. Anybody installing Airflow 1.10.10 backed by MSSQL will encounter this error.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.