BugFix: DAG trigger via UI error in RBAC UI #8411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Apr 17, 2020
| @@ -1062,6 +1062,7 @@ def trigger(self, session=None): | |||
| conf=conf | |||
| ) | |||
|
|
|||
| dag = dagbag.get_dag(dag_id) | |||
There was a problem hiding this comment.
Lol what? Do we have no tests of this?
There was a problem hiding this comment.
This only errors if the Webserver does not have access to Dag Files (like was mentioned in the issue when the DAGs dir was not mounted to Webserver).
We might have tests to see when the config is enabled this still works but we might not have tests to check the Webserver doesn't have access to Dag file.
Have kept the PR in draft so that I can add some tests.
There was a problem hiding this comment.
@ashb I have added the tests to cover this case.
There was a problem hiding this comment.
I will add these tests to Master too once this PR is merged
kaxil
changed the title
kaxil
changed the title
ashb
approved these changes
Apr 21, 2020
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
May 4, 2020
resolves apache#8247 (cherry picked from commit cf43394)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8247
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.