Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case when the pidfile is empty during the pidfile check #8462

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Apr 19, 2020

Bug was introduced with commit that has not been cherry-picked to 1.10: 77bc480


Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth including in 1.10.11 ? Is there a related Bug/Issue that exists? If so, would be great to add details (PR Description) or link to the issue. If not, doesn't matter

@potiuk
Copy link
Member Author

potiuk commented Apr 20, 2020

It's 2.0 thing only I think. I believe It was introduced with commit that has not been cherry-picked to 1.10: 77bc480
Author: Tomek Urbaszek [email protected]
Date: Mon Mar 23 22:32:23 2020 +0100

[AIRFLOW-6624] Improve webserver command with pidfile checking (#7245)

@kaxil
Copy link
Member

kaxil commented Apr 20, 2020

It's 2.0 thing only I think. I believe It was introduced with commit that has not been cherry-picked to 1.10: 77bc480
Author: Tomek Urbaszek [email protected]
Date: Mon Mar 23 22:32:23 2020 +0100

[AIRFLOW-6624] Improve webserver command with pidfile checking (#7245)

Got it 👍

@kaxil
Copy link
Member

kaxil commented Apr 20, 2020

It's 2.0 thing only I think. I believe It was introduced with commit that has not been cherry-picked to 1.10: 77bc480
Author: Tomek Urbaszek [email protected]
Date: Mon Mar 23 22:32:23 2020 +0100
[AIRFLOW-6624] Improve webserver command with pidfile checking (#7245)

Got it 👍

Added description to the PR

@potiuk potiuk merged commit f4faed6 into apache:master Apr 20, 2020
@potiuk potiuk deleted the pid-file-might-be-empty-during-pidfile-check branch April 20, 2020 00:32
@potiuk potiuk modified the milestone: Airflow 1.10.11 Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants