Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json string escape in tree view #8551

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Fix json string escape in tree view #8551

merged 1 commit into from
Apr 27, 2020

Conversation

houqp
Copy link
Member

@houqp houqp commented Apr 25, 2020

close #8523.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 25, 2020
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this? There are some good examples for twst_views.py for TriggerDag and checking response

Example:

@mock.patch('airflow.www.views.dagbag.get_dag')
def test_trigger_endpoint_uses_existing_dagbag(self, mock_get_dag):
"""
Test that Trigger Endpoint uses the DagBag already created in views.py
instead of creating a new one.
"""
mock_get_dag.return_value = DAG(dag_id='example_bash_operator')
url = 'trigger?dag_id=example_bash_operator'
resp = self.client.post(url, data={}, follow_redirects=True)
mock_get_dag.assert_called_once_with('example_bash_operator')
self.check_content_in_response('example_bash_operator', resp)

@houqp
Copy link
Member Author

houqp commented Apr 25, 2020

@kaxil test added.

@kaxil
Copy link
Member

kaxil commented Apr 27, 2020

Thanks @houqp

@kaxil kaxil merged commit bcbd888 into apache:master Apr 27, 2020
@kaxil kaxil added this to the Airflow 1.10.11 milestone Apr 27, 2020
kaxil pushed a commit that referenced this pull request Jun 23, 2020
potiuk pushed a commit that referenced this pull request Jun 29, 2020
@kaxil kaxil added the type:improvement Changelog: Improvements label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Json Parse Error in Tree View
2 participants