-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix json string escape in tree view #8551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
reviewed
Apr 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for this? There are some good examples for twst_views.py for TriggerDag and checking response
Example:
airflow/tests/www/test_views.py
Lines 2225 to 2235 in 5a47e80
@mock.patch('airflow.www.views.dagbag.get_dag') | |
def test_trigger_endpoint_uses_existing_dagbag(self, mock_get_dag): | |
""" | |
Test that Trigger Endpoint uses the DagBag already created in views.py | |
instead of creating a new one. | |
""" | |
mock_get_dag.return_value = DAG(dag_id='example_bash_operator') | |
url = 'trigger?dag_id=example_bash_operator' | |
resp = self.client.post(url, data={}, follow_redirects=True) | |
mock_get_dag.assert_called_once_with('example_bash_operator') | |
self.check_content_in_response('example_bash_operator', resp) |
@kaxil test added. |
kaxil
approved these changes
Apr 27, 2020
Thanks @houqp |
kaxil
pushed a commit
that referenced
this pull request
Jun 23, 2020
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
close apache#8523. (cherry-picked from bcbd888)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8523.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.