Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Local Filesystem Secret Backend (v1-10) #8596

Merged
merged 5 commits into from
Apr 29, 2020
Merged

Add Local Filesystem Secret Backend (v1-10) #8596

merged 5 commits into from
Apr 29, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Apr 28, 2020

Backport: #8436

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@mik-laj mik-laj requested a review from kaxil April 28, 2020 02:17
kaxil
kaxil reviewed Apr 28, 2020
View reviewed changes
airflow/exceptions.py Outdated Show resolved Hide resolved
kaxil
kaxil reviewed Apr 28, 2020
View reviewed changes
airflow/utils/code_utils.py Outdated Show resolved Hide resolved
@mik-laj
Copy link
Member Author

mik-laj commented Apr 28, 2020

@kaxil Github Action is green. Can I ask for review?

kaxil
kaxil approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, thanks for the backport PR @mik-laj , appreciate it :)

@kaxil kaxil merged commit 2970a25 into apache:v1-10-test Apr 29, 2020
@kaxil kaxil added this to the Airflow 1.10.11 milestone Apr 29, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
@mik-laj @kaxil
Add Local Filesystem Secret Backend (v1-10) (#8596)
69eeeda 
Backport of #8436
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@mik-laj
Add Local Filesystem Secret Backend (v1-10) (apache#8596)
2507756 
Backport of apache#8436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxil kaxil kaxil approved these changes

Assignees
No one assigned
Labels
area:secrets
Projects
None yet
Milestone
Airflow 1.10.11
Development

Successfully merging this pull request may close these issues.
2 participants
@mik-laj @kaxil