Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fetching logs from running pods #8626

Merged
merged 5 commits into from
May 3, 2020

Conversation

msumit
Copy link
Contributor

@msumit msumit commented Apr 29, 2020

We are using KubernetesExecutor without any centralized PV for log storage, and hate to wait to see logs until the task finishes and pushes them to GCS. Felt that trying to fetch logs from workers via Airflow serve_logs API isn't of any use in the case of K8sExecutors.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@msumit msumit requested review from aoen, dimberman and kaxil April 29, 2020 08:51
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is definitely going to be helpful

@msumit msumit merged commit 19ac45a into apache:master May 3, 2020
@ashb ashb added this to the Airflow 1.10.11 milestone May 5, 2020
dimberman pushed a commit that referenced this pull request Jun 29, 2020
When using KubernetesExecutor without any centralized PV for log storage, one has to wait until the logs get uploaded to cloud storage before viewing them on UI. With this change, the webserver will try to fetch logs from running worker pods and display them.

(cherry picked from commit 19ac45a)
(cherry picked from commit a4a3b8bcea7fe05a7680148cc8fbe85d9a9278b0)
@kaxil kaxil added the type:improvement Changelog: Improvements label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
When using KubernetesExecutor without any centralized PV for log storage, one has to wait until the logs get uploaded to cloud storage before viewing them on UI. With this change, the webserver will try to fetch logs from running worker pods and display them.

(cherry picked from commit 19ac45a)
(cherry picked from commit a4a3b8bcea7fe05a7680148cc8fbe85d9a9278b0)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
When using KubernetesExecutor without any centralized PV for log storage, one has to wait until the logs get uploaded to cloud storage before viewing them on UI. With this change, the webserver will try to fetch logs from running worker pods and display them.

(cherry picked from commit 19ac45a)
(cherry picked from commit a4a3b8bcea7fe05a7680148cc8fbe85d9a9278b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logging type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants