Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs so demo code runs #8678

Merged
merged 3 commits into from
May 10, 2020
Merged

Updated docs so demo code runs #8678

merged 3 commits into from
May 10, 2020

Conversation

JonnyWaffles
Copy link
Contributor

The below edits I believe fix the intended example code

@boring-cyborg
Copy link

boring-cyborg bot commented May 2, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://apache-airflow-slack.herokuapp.com/

@mik-laj mik-laj linked an issue May 3, 2020 that may be closed by this pull request
@kaxil kaxil merged commit 5e1c33a into apache:master May 10, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 10, 2020

Awesome work, congrats on your first merged pull request!

@kaxil kaxil added this to the Airflow 1.10.11 milestone May 10, 2020
kaxil pushed a commit that referenced this pull request Jun 22, 2020
potiuk pushed a commit that referenced this pull request Jun 29, 2020
@kaxil kaxil added the type:doc label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Operator Documentation Typo
2 participants