Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying Executor Class Name in "Base Job" table #8679

Merged
merged 1 commit into from
May 2, 2020
Merged

Fix displaying Executor Class Name in "Base Job" table #8679

merged 1 commit into from
May 2, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented May 2, 2020

Before:
image

After:
image

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil added this to the Airflow 1.10.11 milestone May 2, 2020
@kaxil kaxil requested review from ashb and potiuk May 2, 2020 16:32
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label May 2, 2020
@kaxil kaxil force-pushed the fix-displaying-jobs-table branch from 3675759 to 7c98b15 Compare May 2, 2020 16:33
@kaxil kaxil requested a review from XD-DENG May 2, 2020 16:45
XD-DENG
XD-DENG approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@XD-DENG XD-DENG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaxil kaxil merged commit 0a7b500 into apache:master May 2, 2020
@kaxil kaxil deleted the fix-displaying-jobs-table branch May 2, 2020 17:30
@mik-laj
Copy link
Member

mik-laj commented May 3, 2020

Why does every job need an executor? I think LocalTaskJob doesn't need it.

kaxil added a commit that referenced this pull request Jun 22, 2020
@kaxil
Fix displaying Executor Class Name in "Base Job" table (#8679)
c2e1270 
(cherry picked from commit 0a7b500)
potiuk pushed a commit that referenced this pull request Jun 29, 2020
@kaxil @potiuk
Fix displaying Executor Class Name in "Base Job" table (#8679)
0246f56 
(cherry picked from commit 0a7b500)
@kaxil kaxil added the type:improvement Changelog: Improvements label Jul 1, 2020
kaxil added a commit that referenced this pull request Jul 1, 2020
@kaxil
Fix displaying Executor Class Name in "Base Job" table (#8679)
540d92f 
(cherry picked from commit 0a7b500)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@kaxil
Fix displaying Executor Class Name in "Base Job" table (apache#8679)
6e7934e 
(cherry picked from commit 0a7b500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XD-DENG XD-DENG XD-DENG approved these changes

@ashb ashb Awaiting requested review from ashb

@potiuk potiuk Awaiting requested review from potiuk

Assignees
No one assigned
Labels
area:Scheduler including HA (high availability) scheduler type:improvement Changelog: Improvements
Projects
None yet
Milestone
Airflow 1.10.11
Development

Successfully merging this pull request may close these issues.
3 participants
@kaxil @mik-laj @XD-DENG