Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __repr__ for DagTag so it displays properly in /dagmodel/show #8719

Merged
merged 2 commits into from
May 5, 2020

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented May 5, 2020

Currently Dag Tags are not displayed properly in UI page /dagmodel/show/<dag_id>

This issue exists in both master and 1.10.10

How to Reproduce

1

Before Fix

before_fix

After fix

after_fix


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@XD-DENG XD-DENG requested review from ashb and kaxil May 5, 2020 16:49
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a simple test for this?

@XD-DENG
Copy link
Member Author

XD-DENG commented May 5, 2020

can we add a simple test for this?

Thanks @kaxil . I was thinking of this as well, but didn't do it given it's too simple change.

Let me re-think how I should do it. Will update here.

@kaxil
Copy link
Member

kaxil commented May 5, 2020

can we add a simple test for this?

Thanks @kaxil . I was thinking of this as well, but didn't do it given it's too simple change.

Let me re-think how I should do it. Will update here.

I mean just assert that "repr(ExampleDagTag) == 'ExampleDagTag'"

@XD-DENG
Copy link
Member Author

XD-DENG commented May 5, 2020

Hi @kaxil , unit test is updated. May be a bit "more" than you expected, but I think it's worthwhile

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like it

@XD-DENG XD-DENG merged commit c717d12 into apache:master May 5, 2020
@XD-DENG XD-DENG deleted the feature/show-tag-correctly branch May 5, 2020 18:33
@kaxil kaxil added this to the Airflow 1.10.11 milestone Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 2, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants