-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __repr__ for DagTag so it displays properly in /dagmodel/show #8719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a simple test for this?
Thanks @kaxil . I was thinking of this as well, but didn't do it given it's too simple change. Let me re-think how I should do it. Will update here. |
I mean just assert that "repr(ExampleDagTag) == 'ExampleDagTag'" |
Hi @kaxil , unit test is updated. May be a bit "more" than you expected, but I think it's worthwhile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like it
…pache#8719) (cherry picked from commit c717d12)
Currently Dag Tags are not displayed properly in UI page
/dagmodel/show/<dag_id>
This issue exists in both
master
and1.10.10
How to Reproduce
Before Fix
After fix
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.