Correctly deserialize dagrun_timeout field on DAGs #8735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't deserializing this correctly (it was left as a float) but nothing _was_ using it, and we hadn't explicitly tested it. We already have example dags with this field, so we just need to check for this field.
ashb
force-pushed
the
deserialize_dagrun_timeout
branch
from
3b09d12
to
35b7baa
Compare
kaxil
approved these changes
May 6, 2020
ashb
changed the title
ashb
added a commit
to astronomer/airflow
that referenced
this pull request
May 18, 2020
We weren't deserializing this correctly (it was left as a float) but nothing _was_ using it, and we hadn't explicitly tested it. We already have example dags with this field, so we just need to check for this field. (cherry picked from commit 336aa27)
kaxil
pushed a commit
that referenced
this pull request
Jun 18, 2020
We weren't deserializing this correctly (it was left as a float) but nothing _was_ using it, and we hadn't explicitly tested it. We already have example dags with this field, so we just need to check for this field. (cherry picked from commit 336aa27)
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
We weren't deserializing this correctly (it was left as a float) but nothing _was_ using it, and we hadn't explicitly tested it. We already have example dags with this field, so we just need to check for this field. (cherry picked from commit 336aa27)
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
We weren't deserializing this correctly (it was left as a float) but nothing _was_ using it, and we hadn't explicitly tested it. We already have example dags with this field, so we just need to check for this field. (cherry picked from commit 336aa27)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
We weren't deserializing this correctly (it was left as a float) but nothing _was_ using it, and we hadn't explicitly tested it. We already have example dags with this field, so we just need to check for this field. (cherry picked from commit 336aa27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't deserializing this correctly (it was left as a float) but
nothing was using it, and we hadn't explicitly tested it.
We already have example dags with this field, so we just need to check
for this field.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.