Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test_logging_config.test_reload_module works in spawn mode. #8741

Merged
merged 2 commits into from
May 6, 2020

Conversation

jhtimmins
Copy link
Contributor

Currently, the test_logging_config.test_reload_module test fails when processes are created in spawn mode, because the change in how memory is shared between processes means the test logging configs don't get loaded properly in the child.

This saves the logging config to an environment variable, which is accessible from the child process.

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@ashb ashb merged commit bd29ee3 into apache:master May 6, 2020
@ashb ashb deleted the give-spawn-custom-config branch May 6, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants