Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure storage 0.37.0 is not installable any more #8833

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented May 12, 2020

2020.05.12 release of the azure-storage is not installable any more
(it is deprecated). For now we should switch to latest working
version


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@zhongjiajie
Copy link
Member

CI failed, section flask8, but I think we ignore scripts and dev folder

scripts/ci/pre_commit_yaml_to_cfg.py:96:42: F541 f-string is missing placeholders
scripts/ci/pre_commit_yaml_to_cfg.py:111:46: F541 f-string is missing placeholders
airflow/providers/google/cloud/example_dags/example_presto_to_gcs.py:50:12: F541 f-string is missing placeholders
tests/executors/test_executor_loader.py:74:35: F541 f-string is missing placeholders
airflow/jobs/scheduler_job.py:564:17: E131 continuation line unaligned for hanging indent
tests/models/test_serialized_dag.py:123:17: F541 f-string is missing placeholders
tests/models/test_serialized_dag.py:123:32: F541 f-string is missing placeholders
tests/models/test_serialized_dag.py:123:47: F541 f-string is missing placeholders
dev/send_email.py:41:12: F541 f-string is missing placeholders
dev/send_email.py:42:14: F541 f-string is missing placeholders

@kaxil
Copy link
Member

kaxil commented May 12, 2020

CI failed, section flask8, but I think we ignore scripts and dev folder

scripts/ci/pre_commit_yaml_to_cfg.py:96:42: F541 f-string is missing placeholders
scripts/ci/pre_commit_yaml_to_cfg.py:111:46: F541 f-string is missing placeholders
airflow/providers/google/cloud/example_dags/example_presto_to_gcs.py:50:12: F541 f-string is missing placeholders
tests/executors/test_executor_loader.py:74:35: F541 f-string is missing placeholders
airflow/jobs/scheduler_job.py:564:17: E131 continuation line unaligned for hanging indent
tests/models/test_serialized_dag.py:123:17: F541 f-string is missing placeholders
tests/models/test_serialized_dag.py:123:32: F541 f-string is missing placeholders
tests/models/test_serialized_dag.py:123:47: F541 f-string is missing placeholders
dev/send_email.py:41:12: F541 f-string is missing placeholders
dev/send_email.py:42:14: F541 f-string is missing placeholders

This looks like flake8 released new version !

@kaxil
Copy link
Member

kaxil commented May 12, 2020

CI failed, section flask8, but I think we ignore scripts and dev folder

scripts/ci/pre_commit_yaml_to_cfg.py:96:42: F541 f-string is missing placeholders
scripts/ci/pre_commit_yaml_to_cfg.py:111:46: F541 f-string is missing placeholders
airflow/providers/google/cloud/example_dags/example_presto_to_gcs.py:50:12: F541 f-string is missing placeholders
tests/executors/test_executor_loader.py:74:35: F541 f-string is missing placeholders
airflow/jobs/scheduler_job.py:564:17: E131 continuation line unaligned for hanging indent
tests/models/test_serialized_dag.py:123:17: F541 f-string is missing placeholders
tests/models/test_serialized_dag.py:123:32: F541 f-string is missing placeholders
tests/models/test_serialized_dag.py:123:47: F541 f-string is missing placeholders
dev/send_email.py:41:12: F541 f-string is missing placeholders
dev/send_email.py:42:14: F541 f-string is missing placeholders

This looks like flake8 released new version !

Created a PR to fix those #8841

@kaxil kaxil added this to the Airflow 1.10.11 milestone May 12, 2020
@kaxil
Copy link
Member

kaxil commented May 12, 2020

Can you rebase the PR on the latest master, please?

@potiuk
Copy link
Member Author

potiuk commented May 12, 2020

Oh yeah. Thanks!

2020.05.12 release of the azure-storage is not installable any more
(it is deprecated). For now we should switch to latest working
version
@potiuk potiuk force-pushed the fix-azure-storage-breaking-build branch from 8c319fc to 8223409 Compare May 12, 2020 10:10
@potiuk
Copy link
Member Author

potiuk commented May 12, 2020

Done :). Thanks for fixing the flake errors @kaxil . Been distracted for a short while

@potiuk
Copy link
Member Author

potiuk commented May 12, 2020

Let's wait until it builds, it does not impact regular PRs/builds so no hurry with it

@potiuk potiuk merged commit 01db738 into apache:master May 12, 2020
@potiuk potiuk deleted the fix-azure-storage-breaking-build branch May 12, 2020 11:28
potiuk added a commit that referenced this pull request May 17, 2020
2020.05.12 release of the azure-storage is not installable any more
(it is deprecated). For now we should switch to latest working
version

(cherry picked from commit 01db738)
@felipefb
Copy link
Contributor

I tried to install the azure package now and had a similar error. Is the new version already available?

Collecting azure-storage>=0.34.0; extra == "azure"
 Downloading azure-storage-0.37.0.zip (4.3 kB)
  ERROR: Command errored out with exit status 1:
   command: /usr/local/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-ulhnvfzb/azure-storage/setup.py'"'"'; __file__='"'"'/tmp/pip-install-ulhnvfzb/azure-storage/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-dicvhu77
     cwd: /tmp/pip-install-ulhnvfzb/azure-storage/
  Complete output (19 lines):
  Traceback (most recent call last):
   File "<string>", line 1, in <module>
   File "/tmp/pip-install-ulhnvfzb/azure-storage/setup.py", line 55, in <module>
    raise RuntimeError(message)
  RuntimeError:
  Starting with v0.37.0, the 'azure-storage' meta-package is deprecated and cannot be installed anymore.
  Please install the service specific packages prefixed by `azure` needed for your application.
  The complete list of available packages can be found at:
  https://aka.ms/azsdk/python/all
  Here's a non-exhaustive list of common packages:
  - [azure-storage-blob](https://pypi.org/project/azure-storage-blob) : Blob storage client
  - [azure-storage-file-share](https://pypi.org/project/azure-storage-file-share) : Storage file share client
  - [azure-storage-file-datalake](https://pypi.org/project/azure-storage-file-datalake) : ADLS Gen2 client
  - [azure-storage-queue](https://pypi.org/project/azure-storage-queue): Queue storage client
  ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

@potiuk
Copy link
Member Author

potiuk commented May 18, 2020

It's fixed in master If you try to install released 1.10.10 version in a stable way you should follow the https://github.com/apache/airflow/blob/master/README.md#installing-from-pypi

pip install apache-airflow==1.10.10 \
 --constraint https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt

kaxil pushed a commit to astronomer/airflow that referenced this pull request May 21, 2020
2020.05.12 release of the azure-storage is not installable any more
(it is deprecated). For now we should switch to latest working
version

(cherry picked from commit 01db738)
(cherry picked from commit 01c8db2)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Jun 3, 2020
2020.05.12 release of the azure-storage is not installable any more
(it is deprecated). For now we should switch to latest working
version

(cherry picked from commit 01db738)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Jun 17, 2020
2020.05.12 release of the azure-storage is not installable any more
(it is deprecated). For now we should switch to latest working
version

(cherry picked from commit 01db738)
(cherry picked from commit 01c8db2)
kaxil pushed a commit that referenced this pull request Jul 1, 2020
2020.05.12 release of the azure-storage is not installable any more
(it is deprecated). For now we should switch to latest working
version

(cherry picked from commit 01db738)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
2020.05.12 release of the azure-storage is not installable any more
(it is deprecated). For now we should switch to latest working
version

(cherry picked from commit 01db738)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants