Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - Add TaskInstance State to tiTooltip in RBAC UI #8910

Merged

Conversation

harrisjoseph
Copy link
Contributor

Currently there is no way to determine the state of a TaskInstance in the graph view or tree view, for people with Colour blindness

An estimated 4.5% of people experience some form of colour vision deficiency

I haven't seen any testing around task-instance.js, but will gladly write a test, or update any existing test


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

…ermine the state of a TaskInstance in the graph view or tree view for people with Colour blindness

Approximately 4.5% of people experience some form of colour vision deficiency
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label May 19, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 19, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://apache-airflow-slack.herokuapp.com/

@ashb ashb self-requested a review May 20, 2020 10:26
@harrisjoseph
Copy link
Contributor Author

Screenshots of the updated tooltip for reference:
Screenshot 2020-05-20 at 13 25 25
Screenshot 2020-05-20 at 13 25 34

@ashb ashb merged commit f3f74c7 into apache:master May 21, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 21, 2020

Awesome work, congrats on your first merged pull request!

@ashb
Copy link
Member

ashb commented May 21, 2020

Thanks @harrisjoseph (:gb: :pencil2: FTW.)

@ashb ashb added this to the Airflow 1.10.11 milestone May 21, 2020
@harrisjoseph
Copy link
Contributor Author

Thank you. It's an honour and a privilege. 🙇

@harrisjoseph harrisjoseph deleted the feature/accessibility-ti-state-hover branch May 22, 2020 08:46
kaxil pushed a commit that referenced this pull request Jun 22, 2020
…8910)

Currently there is no way to determine the state of a TaskInstance in the graph view or tree view for people with colour blindness

Approximately 4.5% of people experience some form of colour vision deficiency

(cherry picked from commit f3f74c7)
potiuk pushed a commit that referenced this pull request Jun 29, 2020
…8910)

Currently there is no way to determine the state of a TaskInstance in the graph view or tree view for people with colour blindness

Approximately 4.5% of people experience some form of colour vision deficiency

(cherry picked from commit f3f74c7)
@kaxil kaxil added the type:improvement Changelog: Improvements label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
…8910)

Currently there is no way to determine the state of a TaskInstance in the graph view or tree view for people with colour blindness

Approximately 4.5% of people experience some form of colour vision deficiency

(cherry picked from commit f3f74c7)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
…pache#8910)

Currently there is no way to determine the state of a TaskInstance in the graph view or tree view for people with colour blindness

Approximately 4.5% of people experience some form of colour vision deficiency

(cherry picked from commit f3f74c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants