Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Version of Azure Cosmos to <4 #8956

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented May 21, 2020

Old Repo: https://github.com/Azure/azure-cosmos-python
New Repo: https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/cosmos/azure-cosmos

azure-cosmos==4.0.0 was released on 20 May 2020 that breaks Airflow with Azure dep:

Error:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
    from azure.cosmos.errors import HTTPFailure
ImportError: cannot import name 'HTTPFailure' from 'azure.cosmos.errors'

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested review from ashb and potiuk May 21, 2020 19:12
@kaxil
Copy link
Member Author

kaxil commented May 21, 2020

I am not sure why the test is failing:

************* Module airflow.providers.google.cloud.hooks.datacatalog
airflow/providers/google/cloud/hooks/datacatalog.py:519:15: E1101: Class 'DataCatalogClient' has no 'field_path' member (no-member)
airflow/providers/google/cloud/hooks/datacatalog.py:842:15: E1101: Class 'DataCatalogClient' has no 'field_path' member (no-member)
airflow/providers/google/cloud/hooks/datacatalog.py:1217:38: E1101: Class 'DataCatalogClient' has no 'field_path' member (no-member)

@kaxil
Copy link
Member Author

kaxil commented May 21, 2020

Aah that is because Datacatalogclinet released new version too :(

@kaxil kaxil mentioned this pull request May 21, 2020
6 tasks
@kaxil
Copy link
Member Author

kaxil commented May 21, 2020

Created a followup PR: #8957

@kaxil kaxil merged commit dd72040 into apache:master May 21, 2020
@kaxil kaxil deleted the pin-azure-cosmos branch May 21, 2020 20:59
ashb pushed a commit that referenced this pull request May 22, 2020
@ashb ashb added this to the Airflow 1.10.11 milestone May 22, 2020
dimberman pushed a commit that referenced this pull request May 29, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Jun 3, 2020
kaxil added a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants