-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include missing RBAC roles #9133
Conversation
@potiuk can you review this? |
@thesuperzapper Tests need updating. |
tests/www/test_views.py
Outdated
@@ -1983,7 +1983,7 @@ def test_failed_success(self): | |||
past="false", | |||
) | |||
resp = self.client.post('failed', data=form) | |||
self.check_content_in_response('Redirecting', resp, 302) | |||
self.check_content_in_response('Redirecting', resp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem like the right fix. If it's saying "redirecting" but not issuing a 302 something else needs changing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashb That test has been broken since it was created (mostly because can_failure
was missing).
You're probably right, about 'Redirecting' what content does that POST return?
What text should we check for, other tests in that file check for example_bash_operator
in the response, should this do the same?
@ashb, I have made the change requested, is this PR now acceptable? |
This is a simple fix which includes the missing RBAC roles.
can_failed
RBAC permission for theUser
roleset_failed
RBAC permission is already present in theUser
rolecan_last_dagruns
RBAC permission for theViewer
roleMake sure to mark the boxes below before creating PR: [x]