Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR/issue note in Contribution Workflow Example #9177

Merged
merged 4 commits into from
Jun 8, 2020
Merged

Add PR/issue note in Contribution Workflow Example #9177

merged 4 commits into from
Jun 8, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Jun 8, 2020

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@mik-laj mik-laj requested a review from potiuk June 8, 2020 09:15
@mik-laj
Copy link
Member Author

mik-laj commented Jun 8, 2020

@nullhack Can I ask for review?

nullhack
nullhack suggested changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@nullhack nullhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, will help other new contributors. Just a small change.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
@mik-laj @nullhack
Update CONTRIBUTING.rst
feba86c 
Co-authored-by: Eric Lopes <[email protected]>
nullhack
nullhack reviewed Jun 8, 2020
View reviewed changes
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@mik-laj @nullhack
Update CONTRIBUTING.rst
a480986 
Co-authored-by: Eric Lopes <[email protected]>
@mik-laj mik-laj merged commit 2038b69 into apache:master Jun 8, 2020
@mik-laj mik-laj deleted the mik-laj-patch-4 branch June 8, 2020 11:24
@potiuk potiuk added this to the Airflow 1.10.11 milestone Jun 9, 2020
potiuk pushed a commit that referenced this pull request Jun 9, 2020
@mik-laj @potiuk
Add PR/issue note in Contribution Workflow Example (#9177)
ec12334 
* Add PR/issue note in Contribution Workflow Example

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>
(cherry picked from commit 2038b69)
potiuk pushed a commit that referenced this pull request Jun 20, 2020
@mik-laj @potiuk
Add PR/issue note in Contribution Workflow Example (#9177)
659863d 
* Add PR/issue note in Contribution Workflow Example

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>
(cherry picked from commit 2038b69)
potiuk pushed a commit that referenced this pull request Jun 29, 2020
@mik-laj @potiuk
Add PR/issue note in Contribution Workflow Example (#9177)
26e8336 
* Add PR/issue note in Contribution Workflow Example

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>
(cherry picked from commit 2038b69)
potiuk pushed a commit that referenced this pull request Jun 29, 2020
@mik-laj @potiuk
Add PR/issue note in Contribution Workflow Example (#9177)
957e1a5 
* Add PR/issue note in Contribution Workflow Example

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>
(cherry picked from commit 2038b69)
kaxil pushed a commit that referenced this pull request Jul 1, 2020
@mik-laj @kaxil
Add PR/issue note in Contribution Workflow Example (#9177)
339184f 
* Add PR/issue note in Contribution Workflow Example

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>
(cherry picked from commit 2038b69)
kaxil pushed a commit that referenced this pull request Jul 1, 2020
@mik-laj @kaxil
Add PR/issue note in Contribution Workflow Example (#9177)
13461c5 
* Add PR/issue note in Contribution Workflow Example

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>
(cherry picked from commit 2038b69)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@mik-laj
Add PR/issue note in Contribution Workflow Example (apache#9177)
37552d9 
* Add PR/issue note in Contribution Workflow Example

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>
(cherry picked from commit 2038b69)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@mik-laj
Add PR/issue note in Contribution Workflow Example (apache#9177)
2e61b0b 
* Add PR/issue note in Contribution Workflow Example

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>

* Update CONTRIBUTING.rst

Co-authored-by: Eric Lopes <[email protected]>
(cherry picked from commit 2038b69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@nullhack nullhack nullhack approved these changes

Assignees
No one assigned
Labels
area:dev-tools
Projects
None yet
Milestone
Airflow 1.10.11
Development

Successfully merging this pull request may close these issues.
3 participants
@mik-laj @potiuk @nullhack