Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove httplib2 from Google requirements #9194

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Jun 9, 2020

We don't use this library directly, so we can rely on the requirements of other libraries.
On the other hand, this requirement conflicts with Apache Beam v2.19 ('httplib2>=0.8,<=0.12.0',). It is latest supported version Apache Beam by Apache Airflow Apache Beam v 2.22 has less strict requirements. (httplib2>=0.8,<0.18.0',), but it's not supported yet.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@mik-laj mik-laj requested review from potiuk and turbaszek June 9, 2020 11:52
@potiuk potiuk merged commit 6d4972a into apache:master Jun 9, 2020
@potiuk potiuk deleted the mik-laj-patch-4 branch June 9, 2020 18:33
@ashb ashb added this to the Airflow 1.10.11 milestone Jun 9, 2020
potiuk pushed a commit that referenced this pull request Jun 20, 2020
* Remove httplib2 from Google requirements

* fixup! Remove httplib2 from Google requirements

(cherry picked from commit 6d4972a)
potiuk pushed a commit that referenced this pull request Jun 29, 2020
* Remove httplib2 from Google requirements

* fixup! Remove httplib2 from Google requirements

(cherry picked from commit 6d4972a)
kaxil pushed a commit that referenced this pull request Jul 1, 2020
* Remove httplib2 from Google requirements

* fixup! Remove httplib2 from Google requirements

(cherry picked from commit 6d4972a)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
* Remove httplib2 from Google requirements

* fixup! Remove httplib2 from Google requirements

(cherry picked from commit 6d4972a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants