-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved compatibility with Python 3.5+ - Convert signal.SIGTERM to int #9207
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
Awesome work, congrats on your first merged pull request! |
@phill84 I'm glad you decided to contribute to this project. What are your plans? Anything else you would like to improve in the project? |
@mik-laj Thanks for helping get this fix merged! I am usually a couple minors behind the latest release, so this is actually the first bug I found that hasn't been fixed in master. Let's hope that I won't open new PR's too soon or often, at least for time being. 😸 |
… int (#9207) Co-authored-by: Jiening Wen <[email protected]> (cherry picked from commit 1cf52da)
… int (#9207) Co-authored-by: Jiening Wen <[email protected]> (cherry picked from commit 1cf52da)
… int (#9207) Co-authored-by: Jiening Wen <[email protected]> (cherry picked from commit 1cf52da)
… int (apache#9207) Co-authored-by: Jiening Wen <[email protected]> (cherry picked from commit 1cf52da)
Solves the issue #9202
File changed:
airflow/utils/process_utils.py
Problem
Since python3.5, signals have become
IntEnum
instead ofint
, thereforestr(signal.SIGTERM)
yields the string literalsignal.SIGTERM
instead of15
.Solution
convert
signal.SIGTERM
toint
first and thenstr
unnecessary