-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for the ThresholdCheckOperator problem #9312
Fix for the ThresholdCheckOperator problem #9312
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
@DanilBaibak We had problems with CI. Can you do rebase? |
8da5b92
to
bbbf785
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Presto the suggested fix solves the issue.
[2020-06-17 20:40:59,820] {playground.py:197} INFO - Log from test-fix:
result: 4
task_id: threshold_check_new
min_threshold: 1.0
max_threshold: 6.0
within_threshold: True
[2020-06-17 20:40:59,820] {playground.py:188} INFO - Test threshold_check_new Successful.
bbbf785
to
62ae275
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanilBaibak Can you do a rebase? This change is a bit old.
62ae275
to
42cd547
Compare
Awesome work, congrats on your first merged pull request! |
(cherry picked from commit 87d83a1)
(cherry picked from commit 87d83a1)
(cherry picked from commit 87d83a1)
The fix for the issue #9309 regarding the problem with ThresholdCheckOperator.
Make sure to mark the boxes below before creating PR: [x]