Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the ThresholdCheckOperator problem #9312

Merged

Conversation

DanilBaibak
Copy link
Contributor

The fix for the issue #9309 regarding the problem with ThresholdCheckOperator.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 15, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://apache-airflow-slack.herokuapp.com/

@mik-laj
Copy link
Member

mik-laj commented Jun 17, 2020

@DanilBaibak We had problems with CI. Can you do rebase?

@DanilBaibak DanilBaibak force-pushed the Fix-ThresholdCheckOperator-Does-Not-Work branch from 8da5b92 to bbbf785 Compare June 17, 2020 19:24
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Presto the suggested fix solves the issue.

[2020-06-17 20:40:59,820] {playground.py:197} INFO - Log from test-fix:
result: 4
task_id: threshold_check_new
min_threshold: 1.0
max_threshold: 6.0
within_threshold: True
[2020-06-17 20:40:59,820] {playground.py:188} INFO - Test threshold_check_new Successful.

@DanilBaibak DanilBaibak force-pushed the Fix-ThresholdCheckOperator-Does-Not-Work branch from bbbf785 to 62ae275 Compare June 19, 2020 07:51
@DanilBaibak
Copy link
Contributor Author

Hi @mik-laj! Seems, tests passed and @eladkal tested the fix. Can we move forward with PR?

Copy link
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanilBaibak Can you do a rebase? This change is a bit old.

@DanilBaibak DanilBaibak force-pushed the Fix-ThresholdCheckOperator-Does-Not-Work branch from 62ae275 to 42cd547 Compare June 30, 2020 14:28
@mik-laj mik-laj merged commit 87d83a1 into apache:master Jun 30, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 30, 2020

Awesome work, congrats on your first merged pull request!

@kaxil kaxil added this to the Airflow 1.10.12 milestone Jul 6, 2020
kaxil pushed a commit that referenced this pull request Aug 12, 2020
kaxil pushed a commit that referenced this pull request Aug 15, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants