Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy button to Code Blocks in Airflow Docs #9450

Merged
merged 2 commits into from
Jun 20, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jun 20, 2020

Before 1:

image

After 1:

image

Before 2:
image

After 2:
image


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested a review from potiuk June 20, 2020 19:34
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kaxil kaxil merged commit 5b820a7 into apache:master Jun 20, 2020
@kaxil kaxil deleted the copy-codeblocks branch June 20, 2020 20:03
kaxil added a commit to kaxil/airflow that referenced this pull request Jun 27, 2020
@kaxil kaxil added this to the Airflow 1.10.11 milestone Jun 29, 2020
kaxil added a commit that referenced this pull request Jun 30, 2020
@kaxil kaxil added the type:doc label Jul 1, 2020
kaxil added a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants