Fix clear future recursive when ExternalTaskMarker is used #9515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqian90
force-pushed
the
fix_clear_future_recursive
branch
from
61c33b2
to
902e1a2
Compare
kaxil
approved these changes
Aug 14, 2020
kaxil
pushed a commit
that referenced
this pull request
Aug 14, 2020
(cherry picked from commit 4454224)
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
(cherry picked from commit 4454224)
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
(cherry picked from commit 4454224)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
(cherry picked from commit 4454224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug reported in #9514
What happened:
In example_external_task_marker_dag.py, after the Dags have been run over multiple dates, when the user clears parent_task on the first execution_date with Future, Downstream and Recursive selected, the current behaviour is that Airflow clears the parent dag tasks over all execution_dates, but only clears the first execution_date of the child dag.
What you expected to happen:
Airflow should clear all tasks on the parent DAG and child DAG over all execution_dates.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.