Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the default value for store_dag_code #9554

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Fix the default value for store_dag_code #9554

merged 2 commits into from
Jun 29, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jun 28, 2020

related to #8255 (fixes the issue mentioned with store_dag_code but does not address Config interpolation)

The default value of store_dag_code should be same as store_serialized_dags setting. But if the value is set it should use that value

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil
Fix the default value for store_dag_code
8ec8284 
related to apache#8255 (fixes the issue mentioned with `store_dag_code` but does not address Config interpolation)

The default value of `store_dag_code` should be same as `store_serialized_dags` setting.  But if the value is set it should use that value
@kaxil kaxil added this to the Airflow 1.10.11 milestone Jun 28, 2020
@kaxil kaxil requested a review from ashb June 28, 2020 15:28
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Jun 28, 2020
@mik-laj mik-laj mentioned this pull request Jun 28, 2020
Merged
6 tasks
@kaxil kaxil force-pushed the default-value-for-store-dag-code branch from 6112670 to c2681d0 Compare June 29, 2020 11:11
@kaxil kaxil merged commit 57c722b into apache:master Jun 29, 2020
@kaxil kaxil deleted the default-value-for-store-dag-code branch June 29, 2020 11:46
kaxil added a commit to astronomer/airflow that referenced this pull request Jun 29, 2020
@kaxil
Fix failing test in DagCode
b922d4c 
PR apache#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully
@kaxil kaxil mentioned this pull request Jun 29, 2020
Merged
6 tasks
kaxil added a commit that referenced this pull request Jun 29, 2020
@kaxil
Fix failing test in DagCode (#9565)
ee03353 
PR #9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully
kaxil added a commit that referenced this pull request Jun 29, 2020
@kaxil
Fix the default value for store_dag_code (#9554)
a0fc255 
related to #8255 (fixes the issue mentioned with `store_dag_code` but does not address Config interpolation)

The default value of `store_dag_code` should be same as `store_serialized_dags` setting.  But if the value is set it should use that value

(cherry picked from commit 57c722b)
kaxil added a commit that referenced this pull request Jun 29, 2020
@kaxil
Fix failing test in DagCode (#9565)
3f1ea4f 
PR #9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

(cherry picked from commit ee03353)
@kaxil kaxil added the type:improvement Changelog: Improvements label Jul 1, 2020
kaxil added a commit that referenced this pull request Jul 1, 2020
@kaxil
Fix the default value for store_dag_code (#9554)
ee23fe9 
related to #8255 (fixes the issue mentioned with `store_dag_code` but does not address Config interpolation)

The default value of `store_dag_code` should be same as `store_serialized_dags` setting.  But if the value is set it should use that value

(cherry picked from commit 57c722b)
kaxil added a commit that referenced this pull request Jul 1, 2020
@kaxil
Fix failing test in DagCode (#9565)
a0e2753 
PR #9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

(cherry picked from commit ee03353)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@kaxil
Fix the default value for store_dag_code (apache#9554)
8b59bb3 
related to apache#8255 (fixes the issue mentioned with `store_dag_code` but does not address Config interpolation)

The default value of `store_dag_code` should be same as `store_serialized_dags` setting.  But if the value is set it should use that value

(cherry picked from commit 57c722b)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@kaxil
Fix failing test in DagCode (apache#9565)
176f8c0 
PR apache#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

(cherry picked from commit ee03353)
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 4, 2021
@kaxil
Fix failing test in DagCode (#9565)
37cb66f 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

(cherry picked from commit ee0335315e421c8ce9e826f7ac5e8f4c82f171fe)

GitOrigin-RevId: a0e275348d5bd97d2fef05c984d415049bc5c826
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 4, 2021
@kaxil
Fix failing test in DagCode (#9565)
2ac1b12 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

(cherry picked from commit ee0335315e421c8ce9e826f7ac5e8f4c82f171fe)

GitOrigin-RevId: a0e275348d5bd97d2fef05c984d415049bc5c826
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 9, 2021
@kaxil
Fix failing test in DagCode (#9565)
2066214 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

(cherry picked from commit ee0335315e421c8ce9e826f7ac5e8f4c82f171fe)

GitOrigin-RevId: a0e275348d5bd97d2fef05c984d415049bc5c826
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 15, 2021
@kaxil
Fix failing test in DagCode (#9565)
f6fadf3 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2021
@kaxil
Fix failing test in DagCode (#9565)
3a5615c 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021
@kaxil
Fix failing test in DagCode (#9565)
09dc2e2 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 25, 2021
@kaxil
Fix failing test in DagCode (#9565)
cffe3a8 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 9, 2022
@kaxil
Fix failing test in DagCode (#9565)
5d0303b 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 3, 2022
@kaxil
Fix failing test in DagCode (#9565)
e28d640 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 6, 2022
@kaxil
Fix failing test in DagCode (#9565)
81fa376 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 8, 2022
@kaxil
Fix failing test in DagCode (#9565)
70fdf81 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022
@kaxil
Fix failing test in DagCode (#9565)
31c9a0c 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
@kaxil
Fix failing test in DagCode (#9565)
1a9c847 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
@kaxil
Fix failing test in DagCode (#9565)
5bac1c8 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
@kaxil
Fix failing test in DagCode (#9565)
96449d9 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
@kaxil
Fix failing test in DagCode (#9565)
87f06ea 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 11, 2024
@kaxil
Fix failing test in DagCode (#9565)
48802f9 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
@kaxil
Fix failing test in DagCode (#9565)
99c5f75 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 16, 2024
@kaxil
Fix failing test in DagCode (#9565)
1eaa0f6 
PR apache/airflow#9554 introduced this error and because of Github issue currently (github is down / has degraded performance) the CI didn't run fully

GitOrigin-RevId: ee0335315e421c8ce9e826f7ac5e8f4c82f171fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashb ashb ashb approved these changes

Assignees
No one assigned
Labels
area:Scheduler including HA (high availability) scheduler type:improvement Changelog: Improvements
Projects
None yet
Milestone
Airflow 1.10.11
Development

Successfully merging this pull request may close these issues.
2 participants
@kaxil @ashb