Makes multi-namespace mode optional #9570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:Scheduler
kaxil
approved these changes
Jun 29, 2020
turbaszek
approved these changes
Jun 29, 2020
mik-laj
approved these changes
Jun 29, 2020
dimberman
force-pushed
the
fix-multi-namespace
branch
from
b1c6d3b
to
f65ae00
Compare
potiuk
reviewed
Jun 29, 2020
Dockerfile.ci
Outdated
| "https://github.com/${AIRFLOW_REPO}/archive/${AIRFLOW_BRANCH}.tar.gz#egg=apache-airflow[${AIRFLOW_EXTRAS}]" \ | ||
| --constraint "https://raw.githubusercontent.com/${AIRFLOW_REPO}/${AIRFLOW_BRANCH}/requirements/requirements-python${PYTHON_MAJOR_MINOR_VERSION}.txt" \ | ||
| && pip uninstall --yes apache-airflow; | ||
| # And is automatically reinstalled from the scratch every month |
There was a problem hiding this comment.
I think this brings some old Dockerfile code back which is not valid any more.
There was a problem hiding this comment.
Earlier this change was not here, as I did reviews.
mik-laj
reviewed
Jun 30, 2020
airflow/utils/dag_processing.py
Outdated
| self._concurrency: int = dag.concurrency | ||
| self._pickle_id: Optional[str] = pickle_id | ||
| self._task_special_args: Dict[str, Any] = {} | ||
| def __init__(self, dag, pickle_id=None): |
dimberman
force-pushed
the
fix-multi-namespace
branch
from
1f05a2f
to
f448c88
Compare
Running the airflow k8sexecutor with multiple namespace abilities requires creating a ClusterRole which can break existing deployments
dimberman
force-pushed
the
fix-multi-namespace
branch
from
f448c88
to
8780363
Compare
dimberman
added a commit
that referenced
this pull request
Aug 11, 2020
Running the airflow k8sexecutor with multiple namespace abilities requires creating a ClusterRole which can break existing deployments Co-authored-by: Daniel Imberman <[email protected]> (cherry picked from commit 2e3c878)
kaxil
pushed a commit
that referenced
this pull request
Aug 11, 2020
Running the airflow k8sexecutor with multiple namespace abilities requires creating a ClusterRole which can break existing deployments Co-authored-by: Daniel Imberman <[email protected]> (cherry picked from commit 2e3c878)
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
Running the airflow k8sexecutor with multiple namespace abilities requires creating a ClusterRole which can break existing deployments Co-authored-by: Daniel Imberman <[email protected]> (cherry picked from commit 2e3c878)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Running the airflow k8sexecutor with multiple namespace abilities requires creating a ClusterRole which can break existing deployments Co-authored-by: Daniel Imberman <[email protected]> (cherry picked from commit 2e3c878)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the airflow k8sexecutor with multiple namespace abilities
requires creating a ClusterRole which can break existing deployments
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.