Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pfromat instead of str to render arguments in WebUI #9587

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

turbaszek
Copy link
Member

@turbaszek turbaszek commented Jun 30, 2020

Large dictionaries that are part of operators input renders to hard to read form:
Screenshot 2020-06-30 at 11 20 04

This PR proposes to use pformat instead of str to render the value:
Screenshot 2020-06-30 at 11 19 25


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jun 30, 2020
@turbaszek turbaszek changed the title Use pformat instead of str Use pfromat instead of str to render arguments in WebUI Jun 30, 2020
@turbaszek turbaszek marked this pull request as ready for review June 30, 2020 10:20
@turbaszek turbaszek merged commit 7f70f6f into apache:master Jun 30, 2020
@turbaszek turbaszek deleted the use-pformat-instead-of-str branch June 30, 2020 10:21
@kaxil
Copy link
Member

kaxil commented Jun 30, 2020

Nice one @turbaszek

turbaszek added a commit that referenced this pull request Jun 30, 2020
@kaxil kaxil added this to the Airflow 1.10.11 milestone Jun 30, 2020
@kaxil kaxil added the type:improvement Changelog: Improvements label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants