Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change worker_refresh_interval fallback to default of 30 #9588

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jun 30, 2020

The default value for worker_refresh_interval is 30 (https://airflow.readthedocs.io/en/latest/configurations-ref.html#worker-refresh-interval), so we should align the fallback to 30 too


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

The default value for worker_refresh_interval is 30, so we should align the fallback to 30 too
@kaxil kaxil requested a review from potiuk June 30, 2020 11:04
@boring-cyborg boring-cyborg bot added area:CLI area:webserver Webserver related Issues labels Jun 30, 2020
@kaxil kaxil requested a review from mik-laj June 30, 2020 11:13
@kaxil kaxil merged commit b6c27f2 into apache:master Jun 30, 2020
@kaxil kaxil deleted the fallback-wri-30 branch June 30, 2020 11:59
kaxil added a commit that referenced this pull request Jun 30, 2020
The default value for worker_refresh_interval is 30, so we should align the fallback to 30 too

(cherry picked from commit b6c27f2)
@kaxil kaxil added this to the Airflow 1.10.11 milestone Jul 1, 2020
@kaxil kaxil added the type:improvement Changelog: Improvements label Jul 1, 2020
kaxil added a commit that referenced this pull request Jul 1, 2020
The default value for worker_refresh_interval is 30, so we should align the fallback to 30 too

(cherry picked from commit b6c27f2)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
The default value for worker_refresh_interval is 30, so we should align the fallback to 30 too

(cherry picked from commit b6c27f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants