Add Snowflake support to SQL operator and sensor #9843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
turbaszek
reviewed
Jul 15, 2020
| @@ -80,6 +80,7 @@ | |||
| "postgres": ("airflow.providers.postgres.hooks.postgres.PostgresHook", "postgres_conn_id"), | |||
| "presto": ("airflow.providers.presto.hooks.presto.PrestoHook", "presto_conn_id"), | |||
| "redis": ("airflow.providers.redis.hooks.redis.RedisHook", "redis_conn_id"), | |||
| "snowflake": ("airflow.providers.snowflake.hooks.snowflake.SnowflakeHook", "snowflake_conn_id"), | |||
There was a problem hiding this comment.
Would you mind adding a simple test to check that all hooks' path are valid? For example using importlib? We can try to use airflow.utils.module_loading.import_string
There was a problem hiding this comment.
@turbaszek Added, but requires updating the MSSQL mapping to ODBC per deprecation notice. Since pymssql is deprecated, the existing hook throws an import error for the existing MSSQL mapping.
There was a problem hiding this comment.
Good! In this way, you've found a bug 👌
turbaszek
reviewed
Jul 16, 2020
tests/models/test_connection.py
Outdated
Comment on lines
539
to
540
| for conn_type in CONN_TYPE_TO_HOOK: | ||
| self.assertTrue(issubclass(import_string(CONN_TYPE_TO_HOOK[conn_type][0]), BaseHook)) |
There was a problem hiding this comment.
Suggested change
| for conn_type in CONN_TYPE_TO_HOOK: | |
| self.assertTrue(issubclass(import_string(CONN_TYPE_TO_HOOK[conn_type][0]), BaseHook)) | |
| for hook_path, _ in CONN_TYPE_TO_HOOK.values(): | |
| self.assertTrue(issubclass(import_string(hook_path), BaseHook)) |
WDYT?
There was a problem hiding this comment.
LGTM. This is much cleaner.
turbaszek
approved these changes
Jul 17, 2020
|
Awesome work, congrats on your first merged pull request! |
scrambldchannel
pushed a commit
to scrambldchannel/airflow
that referenced
this pull request
Jul 17, 2020
* Add Snowflake support to SQL operator and sensor * Add test for conn_type to valid hook mapping * Improve code quality for conn type mapping test
|
Marked for inclusion to 1.10.12. Should be easy to cherry-pick |
kaxil
pushed a commit
that referenced
this pull request
Aug 12, 2020
* Add Snowflake support to SQL operator and sensor * Add test for conn_type to valid hook mapping * Improve code quality for conn type mapping test (cherry picked from commit 9c68e7c)
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
* Add Snowflake support to SQL operator and sensor * Add test for conn_type to valid hook mapping * Improve code quality for conn type mapping test (cherry picked from commit 9c68e7c)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Add Snowflake support to SQL operator and sensor * Add test for conn_type to valid hook mapping * Improve code quality for conn type mapping test (cherry picked from commit 9c68e7c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Snowflake as supported database backend for SQL operator and sensor. This is primarily an update to the
allowed_conn_typesets for the corresponding classes.Closes #9548
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.