-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python base image version is retrieved in the right place #9931
Python base image version is retrieved in the right place #9931
Conversation
@kaxil @dimberman - this was the root cause for the wrongly generated requirements from Breeze. The temporary fix to solve 3.8.4 base image had some unforeseen consequences (in Breeze, not in the CI so only requirements generation was impacted). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tests for the tests 😄
When quick-fixing Python 3.8.4 error apache#9820 PYTHON_BASE_IMAGE_VERSION variable was added but it was initialized too early in Breeze and it took the default version of Python rather than the one chosen by --python switch. This caused the generated requirements (locally by Breeze only) to generate wrong set of requirements and images built locally for different python versions were based on default Python version, not the one chosen by --python switch.
e1be574
to
f669d97
Compare
I already have some :) |
When quick-fixing Python 3.8.4 error #9820 PYTHON_BASE_IMAGE_VERSION variable was added but it was initialized too early in Breeze and it took the default version of Python rather than the one chosen by --python switch. This caused the generated requirements (locally by Breeze only) to generate wrong set of requirements and images built locally for different python versions were based on default Python version, not the one chosen by --python switch. (cherry picked from commit 7b9e8e0)
When quick-fixing Python 3.8.4 error #9820 PYTHON_BASE_IMAGE_VERSION variable was added but it was initialized too early in Breeze and it took the default version of Python rather than the one chosen by --python switch. This caused the generated requirements (locally by Breeze only) to generate wrong set of requirements and images built locally for different python versions were based on default Python version, not the one chosen by --python switch. (cherry picked from commit 7b9e8e0)
When quick-fixing Python 3.8.4 error apache#9820 PYTHON_BASE_IMAGE_VERSION variable was added but it was initialized too early in Breeze and it took the default version of Python rather than the one chosen by --python switch. This caused the generated requirements (locally by Breeze only) to generate wrong set of requirements and images built locally for different python versions were based on default Python version, not the one chosen by --python switch. (cherry picked from commit 7b9e8e0)
When quick-fixing Python 3.8.4 error #9820 PYTHON_BASE_IMAGE_VERSION
variable was added but it was initialized too early in Breeze and
it took the default version of Python rather than the one chosen
by --python switch. This caused the generated requirements
(locally by Breeze only) to generate wrong set of requirements
and images built locally for different python versions were
based on default Python version, not the one chosen by --python
switch.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.