-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make regex for hosts consistent with APISIX #2065
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ashish Tiwari <[email protected]>
Is there a problem with the admin-api mode? |
The admin api is fine. The regex of the same field that admin api expects and what ingress controller expects is different. So this PR makes sure that regex is same for the same field. |
Signed-off-by: Ashish Tiwari <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
+ Coverage 36.81% 37.38% +0.56%
==========================================
Files 93 94 +1
Lines 7863 7971 +108
==========================================
+ Hits 2895 2980 +85
- Misses 4580 4597 +17
- Partials 388 394 +6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
This issue needs to be fixed first for the CI to pass here api7/lua-resty-radixtree#138 |
- name: rule1 | ||
match: | ||
hosts: | ||
- httpbin.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this use case seem unrelated to PR? What about the port?
Waiting on next apisix release with this chaange apache/apisix#10861 |
Type of change:
Fixes #2064
Currently there is a mismatch between the regex that APISIX allowed[1] and what ApisixRoute CRD allowed. This PR makes sure that both are consistent.
More specifically - Both
1.2.3.4
and1.2.3.4:443
should be considered validhosts
fieldapisix-ingress-controller/conf/apisix-schema.json
Line 961 in ea6fbc9
What this PR does / why we need it:
Pre-submission checklist: