Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing links to APISIX consumer pages #2304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sreeram-venkitesh
Copy link

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Added the missing links mentioned in #2289.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@sreeram-venkitesh
Copy link
Author

There seems to be a dead link in the readme file.

### Contributor over time
[![Contributor over time](https://contributor-overtime-api.git-contributor.com/contributors-svg?chart=contributorOverTime&repo=apache/apisix-ingress-controller)](https://git-contributor.com/?chart=contributorOverTime&repo=apache/apisix-ingress-controller)

The new working link seems to be wrapping the old outdated link. This is causing the lint-checker-ci / Check Markdown links task to fail. Shall I fix this as well in the same PR?

@Revolyssup
Copy link
Contributor

There seems to be a dead link in the readme file.

### Contributor over time
[![Contributor over time](https://contributor-overtime-api.git-contributor.com/contributors-svg?chart=contributorOverTime&repo=apache/apisix-ingress-controller)](https://git-contributor.com/?chart=contributorOverTime&repo=apache/apisix-ingress-controller)

The new working link seems to be wrapping the old outdated link. This is causing the lint-checker-ci / Check Markdown links task to fail. Shall I fix this as well in the same PR?

yes please

@sreeram-venkitesh
Copy link
Author

@Revolyssup After looking into it further, I realized that the link is not working because https://git-contributor.com/?chart=contributorOverTime&repo=apache/apisix is down it seems? https://contributor-overtime-api.apiseven.com/repos? is giving an error. There is already an issue created in api7/contributor-graph for this: api7/contributor-graph#231.

I can fix the readme link temporarily and add the image back once this is fixed. Does that sound good?

@sreeram-venkitesh
Copy link
Author

5190e15 would fix the failing CI job. We can add the image back once api7/contributor-graph#231 is resolved. Please take a look!

@sreeram-venkitesh
Copy link
Author

@Revolyssup Please take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants