fix: candidate controllers missing Forget call in workqueue #2308
+7
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users encountered the error:
This error only comes for global rule and only comes in candidate controllers.
Reason:
In current logic, the candidate controllers miss the .Forget() call on the successfully processed object and re-add the object in the workqueue. This fix makes sure that event is removed from the queue when object is processed successfully.
How to reproduce the bug:
Steps To Verify fix: