-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ApisixRoute v2alpha1 #262
Conversation
@gxthrj Please take a look when you have time. |
Conflicting files |
@@ -338,17 +340,6 @@ type Api6Controller struct { | |||
Stop <-chan struct{} | |||
} | |||
|
|||
func (api6 *Api6Controller) ApisixRoute(controller *Controller) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed earlier that we should keep the v1 version for a while, declare in the document "deprecated", and delete the logic of v1 in version 1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I forgot to set this PR to draft, the v1 ApisixRoute will be kept of course.
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 53.85% 52.26% -1.59%
==========================================
Files 33 32 -1
Lines 2245 2319 +74
==========================================
+ Hits 1209 1212 +3
- Misses 879 950 +71
Partials 157 157
Continue to review full report at Codecov.
|
- /ip | ||
backend: | ||
serviceName: %s | ||
servicePort: %d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more test case with v2alpha1. We may add more in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
#248
New feature or improvement
This PR implemented the ApisixRoute.apisix.apache.org/v2/alpha1 resource. Generate the required listers, informers for it.