Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ingress controller compatible with ingress.extensions/v1beta1 #315

Merged
merged 3 commits into from
Mar 27, 2021

Conversation

tokers
Copy link
Contributor

@tokers tokers commented Mar 27, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues

#313


Bugfix

  • Description

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

@tokers tokers linked an issue Mar 27, 2021 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Mar 27, 2021

Codecov Report

Merging #315 (026040d) into master (b5cba04) will increase coverage by 45.74%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           master      #315       +/-   ##
============================================
+ Coverage   54.25%   100.00%   +45.74%     
============================================
  Files          35         1       -34     
  Lines        2479         1     -2478     
============================================
- Hits         1345         1     -1344     
+ Misses        974         0      -974     
+ Partials      160         0      -160     
Impacted Files Coverage Δ
pkg/version/version.go
pkg/kube/translation/util.go
pkg/seven/state/route_worker.go
pkg/apisix/resource.go
pkg/types/errors.go
pkg/id/idgen.go
pkg/log/default_logger.go
pkg/apisix/apisix.go
pkg/apisix/ssl.go
pkg/kube/translation/apisix_route.go
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5cba04...026040d. Read the comment docs.

@gxthrj gxthrj merged commit f539fde into apache:master Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ingress resources in extensions/v1beta1 is not dealt reasonablely
3 participants