Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor the structures of kube clients, shared index informer factories #431

Merged
merged 1 commit into from
May 14, 2021

Conversation

tokers
Copy link
Contributor

@tokers tokers commented May 11, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


Bugfix

  • Description

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

@codecov-commenter
Copy link

Codecov Report

Merging #431 (5b9f043) into master (dc43be8) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   36.58%   36.61%   +0.02%     
==========================================
  Files          43       43              
  Lines        3799     3796       -3     
==========================================
  Hits         1390     1390              
+ Misses       2230     2227       -3     
  Partials      179      179              
Impacted Files Coverage Δ
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_tls.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_upstream.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 0.00% <0.00%> (ø)
pkg/ingress/status.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc43be8...5b9f043. Read the comment docs.

@tokers tokers requested a review from gxthrj May 13, 2021 12:46
@tokers
Copy link
Contributor Author

tokers commented May 13, 2021

@tao12345666333 @gxthrj

@tokers tokers merged commit fb11efc into apache:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants