Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ApisixTls support mTLS #492

Merged
merged 14 commits into from
May 31, 2021
Merged

feat: ApisixTls support mTLS #492

merged 14 commits into from
May 31, 2021

Conversation

lingsamuel
Copy link
Member

Signed-off-by: Ling Samuel [email protected]

Please answer these questions before submitting a pull request


New feature or improvement

  • Describe the details and related test reports.

Support mTLS between client and APISIX.

@lingsamuel lingsamuel changed the title feat: ApisixTls: mutual TLS prototype feat: ApisixTls support mTLS May 25, 2021
@lingsamuel lingsamuel force-pushed the mtls branch 5 times, most recently from f481018 to 0779d3e Compare May 27, 2021 17:30
@lingsamuel lingsamuel marked this pull request as ready for review May 27, 2021 17:31
Signed-off-by: Ling Samuel <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #492 (ecda49b) into master (f089ffe) will increase coverage by 0.16%.
The diff coverage is 1.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   36.28%   36.44%   +0.16%     
==========================================
  Files          50       53       +3     
  Lines        4093     4261     +168     
==========================================
+ Hits         1485     1553      +68     
- Misses       2406     2498      +92     
- Partials      202      210       +8     
Impacted Files Coverage Δ
pkg/ingress/apisix_tls.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 1.20% <0.00%> (+1.20%) ⬆️
pkg/ingress/secret.go 0.00% <0.00%> (ø)
pkg/kube/translation/apisix_ssl.go 0.00% <0.00%> (ø)
pkg/apisix/ssl.go 32.06% <100.00%> (-2.98%) ⬇️
pkg/kube/translation/plugin.go 100.00% <0.00%> (ø)
pkg/kube/translation/translator.go 51.38% <0.00%> (ø)
pkg/types/pod.go 100.00% <0.00%> (ø)
pkg/kube/translation/apisix_consumer.go 73.33% <0.00%> (ø)
pkg/ingress/pod.go 28.88% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f089ffe...ecda49b. Read the comment docs.

docs/en/latest/practices/mtls/tls.yaml Outdated Show resolved Hide resolved
pkg/kube/apisix/apis/config/v1/types.go Outdated Show resolved Hide resolved
test/e2e/scaffold/scaffold.go Outdated Show resolved Hide resolved
@lingsamuel lingsamuel requested review from tokers and gxthrj May 31, 2021 01:33
@lingsamuel lingsamuel requested a review from gxthrj May 31, 2021 01:53
@gxthrj gxthrj merged commit 38290a2 into apache:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request help: supported mTLS in apisix-ingress
4 participants