Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v2beta3 #746

Merged
merged 25 commits into from
Dec 6, 2021
Merged

feat: add v2beta3 #746

merged 25 commits into from
Dec 6, 2021

Conversation

gxthrj
Copy link
Contributor

@gxthrj gxthrj commented Nov 10, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

@gxthrj gxthrj marked this pull request as ready for review November 24, 2021 01:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #746 (77ec0d0) into master (703c6b2) will decrease coverage by 0.07%.
The diff coverage is 26.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
- Coverage   32.50%   32.42%   -0.08%     
==========================================
  Files          66       65       -1     
  Lines        6800     6872      +72     
==========================================
+ Hits         2210     2228      +18     
- Misses       4340     4396      +56     
+ Partials      250      248       -2     
Impacted Files Coverage Δ
pkg/api/validation/apisix_consumer.go 0.00% <0.00%> (ø)
pkg/api/validation/apisix_route.go 21.73% <0.00%> (+2.50%) ⬆️
pkg/api/validation/apisix_tls.go 0.00% <0.00%> (ø)
pkg/api/validation/apisix_upstream.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_cluster_config.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_consumer.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_tls.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_upstream.go 0.00% <0.00%> (ø)
pkg/ingress/compare.go 0.00% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703c6b2...77ec0d0. Read the comment docs.

@tokers
Copy link
Contributor

tokers commented Nov 25, 2021

Can we split this PR to two parts:

  1. Add the new version;
  2. Delete the old versions;

@tao12345666333 tao12345666333 linked an issue Nov 26, 2021 that may be closed by this pull request
5 tasks
@tao12345666333
Copy link
Member

@gxthrj any updates?

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

LGTM! Thanks!

@tao12345666333 tao12345666333 added the enhancement New feature or request label Dec 3, 2021
pkg/config/config.go Outdated Show resolved Hide resolved
@tao12345666333
Copy link
Member

ping @tokers @lingsamuel for review, thanks!

@tao12345666333 tao12345666333 merged commit 1bbadf0 into apache:master Dec 6, 2021
neverCase added a commit to neverCase/apisix-ingress-controller that referenced this pull request Dec 10, 2021
Sindweller pushed a commit to Sindweller/apisix-ingress-controller that referenced this pull request Dec 18, 2021
@tao12345666333 tao12345666333 linked an issue Dec 29, 2021 that may be closed by this pull request
5 tasks
@tao12345666333 tao12345666333 mentioned this pull request Mar 7, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: use a uniform CRD APIVersion
4 participants