Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if stream_routes is disabled #868

Merged
merged 5 commits into from
Mar 2, 2022

Conversation

lingsamuel
Copy link
Member

Signed-off-by: Ling Samuel [email protected]

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Fixes #856

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Ling Samuel <[email protected]>
@tao12345666333
Copy link
Member

@lingsamuel Can we add an e2e test case to cover this scenario?

We need to create a new APISIX configuration file (disable stream_route) and start it.

Signed-off-by: Ling Samuel <[email protected]>
@lingsamuel
Copy link
Member Author

@tao12345666333 done

Signed-off-by: Ling Samuel <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #868 (8dc490f) into master (545d22d) will decrease coverage by 0.11%.
The diff coverage is 8.10%.

❗ Current head 8dc490f differs from pull request most recent head ed9a0ba. Consider uploading reports for the commit ed9a0ba to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
- Coverage   32.07%   31.96%   -0.12%     
==========================================
  Files          71       71              
  Lines        7739     7769      +30     
==========================================
+ Hits         2482     2483       +1     
- Misses       4982     5010      +28     
- Partials      275      276       +1     
Impacted Files Coverage Δ
pkg/apisix/cluster.go 31.44% <0.00%> (-1.14%) ⬇️
pkg/apisix/noop.go 0.00% <0.00%> (ø)
pkg/apisix/stream_route.go 36.42% <50.00%> (+0.12%) ⬆️
test/e2e/e2e.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545d22d...ed9a0ba. Read the comment docs.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333
Copy link
Member

@lingsamuel #829 has been merged. You can try to update code base on master branch. Thanks

@tao12345666333
Copy link
Member

ping @gxthrj @tokers PTAL, thanks!

@tao12345666333 tao12345666333 added bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 1, 2022
Copy link
Contributor

@gxthrj gxthrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: when some features in APISIX are disabled, the shared context will cause some exceptions
5 participants