-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check if stream_routes is disabled #868
Conversation
Signed-off-by: Ling Samuel <[email protected]>
Signed-off-by: Ling Samuel <[email protected]>
@lingsamuel Can we add an e2e test case to cover this scenario? We need to create a new APISIX configuration file (disable stream_route) and start it. |
Signed-off-by: Ling Samuel <[email protected]>
@tao12345666333 done |
Signed-off-by: Ling Samuel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
- Coverage 32.07% 31.96% -0.12%
==========================================
Files 71 71
Lines 7739 7769 +30
==========================================
+ Hits 2482 2483 +1
- Misses 4982 5010 +28
- Partials 275 276 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lingsamuel #829 has been merged. You can try to update code base on master branch. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ling Samuel [email protected]
Type of change:
What this PR does / why we need it:
Fixes #856
Pre-submission checklist: