Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DISCUSS] The error message "got malformed version message from etcd" is ambiguous #2718

Closed
tokers opened this issue Nov 12, 2020 · 6 comments · Fixed by #2965
Closed

[DISCUSS] The error message "got malformed version message from etcd" is ambiguous #2718

tokers opened this issue Nov 12, 2020 · 6 comments · Fixed by #2965
Assignees
@starsz
Labels
enhancement New feature or request

Comments

@tokers
Copy link
Contributor

tokers commented Nov 12, 2020

When the etcd initialization fails, the output error message:

got malformed version message: "" from etcd

Which is ambiguous, i think the error details should be exposed. What do you think?
@Firstsawyou
Copy link
Contributor

I agree with you. I have also encountered such a situation, this prompt message is not clear.

@nic-chen
Copy link
Member

agree +1

@membphis
Copy link
Member

agree +1

BTW, how can we get this error message? is it a bug?

@tokers
Copy link
Contributor Author

tokers commented Nov 18, 2020

agree +1

BTW, how can we get this error message? is it a bug?

It's note a bug but a not so friendly hint when we cannot get the etcd version when the etcd cluster is abnormal, like cluster without leader and we are timed out, or even the cluster is totally offline.

@tokers
Copy link
Contributor Author

tokers commented Nov 18, 2020

@starsz Would you like to optimize this? Thanks!

@tokers tokers added the enhancement New feature or request label Nov 18, 2020
@starsz
Copy link
Contributor

starsz commented Nov 18, 2020

@starsz Would you like to optimize this? Thanks!

No problem. My pleasure!

@starsz starsz mentioned this issue Nov 23, 2020
Closed
@spacewander spacewander mentioned this issue Nov 29, 2020
Closed
@starsz starsz mentioned this issue Dec 4, 2020
Merged
4 tasks
@spacewander spacewander mentioned this issue Jan 5, 2021
Closed
tokers pushed a commit that referenced this issue Jan 7, 2021
@starsz
feat: use luasocket instead of curl in etcd.lua (#2965)
7b5d2ea 
fix: #2818
fix: #2718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@starsz starsz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use luasocket instead of curl in etcd.lua starsz/apisix
5 participants
@membphis @tokers @starsz @nic-chen @Firstsawyou