Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated configuration in the V3 #7482

Closed
11 of 12 tasks
spacewander opened this issue Jul 18, 2022 · 4 comments · Fixed by #7676, #7677, #7683, #7694 or #7695
Closed
11 of 12 tasks

Remove deprecated configuration in the V3 #7482

spacewander opened this issue Jul 18, 2022 · 4 comments · Fixed by #7676, #7677, #7683, #7694 or #7695
Assignees
Milestone

Comments

@spacewander
Copy link
Member

spacewander commented Jul 18, 2022

Description

Let's remove the deprecated configuration in the APISIX v3, including:

  • health_check_retry option
    -- TODO: remove deprecated health_check_retry option in APISIX v3
  • lua_shared_dicts

    apisix/apisix/cli/ops.lua

    Lines 654 to 655 in 2385768

    stderr:write("lua_shared_dicts is deprecated, " ..
    "use custom_lua_shared_dict instead\n")
  • audience in authz-keycloak
    -- Check for deprecated audience attribute and emit warnings if used.
    if conf.audience then
    log.warn("Plugin attribute `audience` is deprecated, use `client_id` instead.")
    if conf.client_id then
    log.warn("Ignoring `audience` attribute in favor of `client_id`.")
    end
    end
  • upstream in mqtt-proxy
  • scheme in proxy-rewrite
  • various apisix.real_ip_xxx options
    {% print("\nDeprecated: apisix.real_ip_header has been moved to nginx_config.http.real_ip_header. apisix.real_ip_header will be removed in the future version. Please use nginx_config.http.real_ip_header first.\n\n") %}
  • some configurations in syslog
    conf.max_retry_count = conf.max_retry_times or conf.max_retry_count
  • some configurations in error-log-logger
    host = {schema_def.host_def, description = "Deprecated, use `tcp.host` instead."},
    port = {type = "integer", minimum = 0, description = "Deprecated, use `tcp.port` instead."},
    tls = {type = "boolean", default = false,
    description = "Deprecated, use `tcp.tls` instead."},
    tls_server_name = {type = "string",
    description = "Deprecated, use `tcp.tls_server_name` instead."},
  • drop support of service_protocol
    service_protocol = {
  • move the disable to _meta
    -- TODO: move the `disable` to `_meta` too

@spacewander spacewander added this to the 3.0 milestone Jul 18, 2022
@bzp2010
Copy link
Contributor

bzp2010 commented Jul 19, 2022

Maybe we can remove old configuration items like port_admin from the configuration file as well? 🤔

@spacewander
Copy link
Member Author

Maybe we can remove old configuration items like port_admin from the configuration file as well? 🤔

LGTM

@spacewander
Copy link
Member Author

We can also remove the expression to determine whether to run the plugin or not inside some plugins (like fault-injection) since #7453 is merged.

@spacewander
Copy link
Member Author

@tzssangglass
Let's submit PRs to remove them when you have free time.
Don't forget to submit PR per task so we can record them in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment