Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: move the disable to _meta #7707

Merged
merged 5 commits into from
Aug 18, 2022
Merged

change: move the disable to _meta #7707

merged 5 commits into from
Aug 18, 2022

Conversation

tzssangglass
Copy link
Member

Description

Fixes #7482

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass tzssangglass marked this pull request as ready for review August 17, 2022 06:25
@soulbird
Copy link
Contributor

Need update doc here: https://github.com/apache/apisix/blob/master/docs/en/latest/terminology/plugin.md#plugin-common-configuration

@tzssangglass
Copy link
Member Author

Need update doc here: https://github.com/apache/apisix/blob/master/docs/en/latest/terminology/plugin.md#plugin-common-configuration

updated

tokers
tokers previously approved these changes Aug 17, 2022
View reviewed changes
soulbird
soulbird previously approved these changes Aug 17, 2022
View reviewed changes
starsz
starsz previously approved these changes Aug 17, 2022
View reviewed changes
spacewander
spacewander reviewed Aug 18, 2022
View reviewed changes
apisix/plugin.lua Outdated Show resolved Hide resolved
docs/en/latest/terminology/plugin.md Outdated Show resolved Hide resolved
@tzssangglass tzssangglass dismissed stale reviews from starsz, soulbird, and tokers via 8f04eb0 August 18, 2022 07:00
@spacewander spacewander merged commit bc9af92 into apache:master Aug 18, 2022
@tzssangglass tzssangglass deleted the IssueNo7482-10 branch August 22, 2022 02:28
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@tzssangglass @Liu-Junlin
change: move the disable to _meta (apache#7707)
899d65d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers approved these changes

@spacewander spacewander spacewander approved these changes

@starsz starsz starsz left review comments

@soulbird soulbird soulbird left review comments

@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated configuration in the V3
5 participants
@tzssangglass @soulbird @spacewander @tokers @starsz