-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add schema validate admin API #10065
feat: add schema validate admin API #10065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need more test cases to cover invalid requests.
"scheme": "https", | ||
"type": "roundrobin", | ||
"nodes": { | ||
"nghttp2.org": 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"nghttp2.org": 1 | |
"httpbin.org": 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
httpbin has been less stable in recent months, and now the community is using nghttp2 more.
Also, regarding schema checking, what matters here is not the actual value, but the type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.
FYI We can use httpbun.org also
This does not affect this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about https://mock.api7.ai/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moonming SGTM.
"scheme": "https", | ||
"type": "roundrobin", | ||
"nodes": { | ||
"nghttp2.org": 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
"scheme": "https", | ||
"type": "roundrobin", | ||
"nodes": { | ||
"nghttp2.org": 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Abhishek Choudhary <[email protected]>
Co-authored-by: Abhishek Choudhary <[email protected]>
Co-authored-by: Abhishek Choudhary <[email protected]>
Just a question: why not doing the schema check automatically before users sending requests to any Admin API endpoints? The current approach, that is to ask users to send requests to a specific |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need more test cases not only in routes
The user's request already run the schema check. |
Description
https://lists.apache.org/thread/6lsbhh4c9ytjmrkr0jt66j5s4vyh482k
Checklist