Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: response-rewrite filters.regex does not apply when content-encoding is gzip #10637

Merged
merged 12 commits into from
Dec 25, 2023
Merged

fix: response-rewrite filters.regex does not apply when content-encoding is gzip #10637

merged 12 commits into from
Dec 25, 2023

Conversation

yuweizzz
Copy link
Contributor

Description

Fixes #10562

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@monkeyDluffy6017
Copy link
Contributor

monkeyDluffy6017 commented Dec 21, 2023 •
edited
Loading

Nice job!

@monkeyDluffy6017 monkeyDluffy6017 mentioned this pull request Dec 21, 2023
Closed
shreemaan-abhishek
shreemaan-abhishek approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!! would you like to contribute support for other encodings? Example: brotli?

@yuweizzz
Copy link
Contributor Author

sure, I will create a new pr.

@monkeyDluffy6017 monkeyDluffy6017 merged commit 8f3b026 into apache:master Dec 25, 2023
30 checks passed
@yuweizzz yuweizzz mentioned this pull request Dec 29, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: response-rewrite filters.regex does not apply when content-encoding: gzip
3 participants
@yuweizzz @monkeyDluffy6017 @shreemaan-abhishek