Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not saving etcd revision #10671

Merged
merged 3 commits into from
Dec 21, 2023
Merged

fix: not saving etcd revision #10671

merged 3 commits into from
Dec 21, 2023

Conversation

monkeyDluffy6017
Copy link
Contributor

@monkeyDluffy6017 monkeyDluffy6017 commented Dec 20, 2023 •
edited
Loading

Description

Due to the fix, the saved etcd revision will be discarded when re-watch etcd, APISIX need to re-traverse all keys in etcd every time, that leads to high cpu usage

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

jiangfucheng
jiangfucheng approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@jiangfucheng jiangfucheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monkeyDluffy6017 monkeyDluffy6017 merged commit 0a85ba4 into apache:master Dec 21, 2023
43 checks passed
@TakiJoe TakiJoe mentioned this pull request Dec 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlinsRan AlinsRan AlinsRan approved these changes

@jiangfucheng jiangfucheng jiangfucheng approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

@shreemaan-abhishek shreemaan-abhishek Awaiting requested review from shreemaan-abhishek

@Revolyssup Revolyssup Awaiting requested review from Revolyssup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monkeyDluffy6017 @jiangfucheng @AlinsRan