Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement credential #11601

Merged
merged 12 commits into from
Sep 26, 2024
Merged

feat: implement credential #11601

merged 12 commits into from
Sep 26, 2024

Conversation

dspo
Copy link
Contributor

@dspo dspo commented Sep 25, 2024

Description

This PR add a resource named credential and implement Admin APIs for it.
Credential is used to hold the authentication credentials for the Consumer.
Credentials are used when multiple credentials need to be configured for a Consumer.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dspo dspo marked this pull request as ready for review September 26, 2024 01:17
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Sep 26, 2024
nic-6443
nic-6443 previously approved these changes Sep 26, 2024
@nic-6443
Copy link
Member

@kayx23 Please help review the documentation part of this PR.

docs/en/latest/admin-api.md Outdated Show resolved Hide resolved
docs/en/latest/admin-api.md Outdated Show resolved Hide resolved
@moonming
Copy link
Member

Is this a break change for using the authentication plugin on consumers?

@dspo
Copy link
Contributor Author

dspo commented Sep 26, 2024

Is this a break change for using the authentication plugin on consumers?

It's not a break change. Users can still use Consumer in the same way as before, and the one change to Consumer is that it is no longer required to have at least one auth plugin.

@dspo dspo requested a review from kayx23 September 26, 2024 03:54
@kayx23
Copy link
Member

kayx23 commented Sep 26, 2024

@kayx23 Please help review the documentation part of this PR.

No additional comments from me for docs.

Copy link
Member

@kayx23 kayx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc lgtm

@moonming moonming merged commit 263143d into apache:master Sep 26, 2024
34 checks passed
@shreemaan-abhishek shreemaan-abhishek mentioned this pull request Oct 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants